Bug 1041

Summary:	Changelog website page performance
Product:	Sudo	Reporter:	Peter F <sudo>
Component:	Documentation	Assignee:	Todd C. Miller <Todd.Miller>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	low
Version:	1.9.11
Hardware:	PC
OS:	All
Attachments:	Screenshot of changelog webpage structure

Description Peter F 2022-10-01 11:36:09 MDT

Created attachment 568 [details]
Screenshot of changelog webpage structure

I'm not really sure where to mention this - it is an issue with the sudo.ws website, not the Sudo package itself.

The changelog page [1] takes about a minute to load in Firefox 105 (and any older version I tried), and makes the dev tools unresponsive in both Firefox and Chrome 105.
Firefox shows the message "The document tree is too deep. The tree will be flattened to 513 elements deep." while loading the page. It appears that the problem is each changelog entry's email address being interpreted as a new opening element (see attached screenshot).

[1] https://www.sudo.ws/releases/changelog/

Comment 1 Todd C. Miller 2022-10-01 14:41:12 MDT

Interesting.  It works fine with chrome but firefox (and to a lesser extent safari) seem to have more trouble with it.  Escaping the &, < and > seems to fix the issue for me.  Can you try it now?

This is a large file, covering almost 30 years of commits.  It would probably help to break it up into multiple pieces.

Comment 2 Peter F 2022-10-01 14:51:54 MDT

I don't see any difference yet, are you using a CDN that could be caching the page?
Adding the escaping sounds like it should work fine, as long as it doesn't mess up the fancy Github emails:

2022-09-12  a1346054  <<a href="/cdn-cgi/l/email-protection" class="__cf_email__" data-cfemail="d3e0e5ebe6eae6ebebf8b2e2e0e7e5e3e6e793a6a0b6a1a0fdbdbca1b6a3bfaafdb4baa7bba6b1fdb0bcbe">[email&#160;protected]</a>>

Comment 3 Todd C. Miller 2022-10-01 16:08:50 MDT

The email obfuscation added by Cloudflare may be causing problems.  I've disabled that so you should not longer see those email-protection redirects.  This fixes the problem for me on Firefox.  Previously I was browsing the master site, not the CDN, so didn't see the changes it made.

Comment 4 Peter F 2022-10-01 16:18:17 MDT

This is great, the page looks like it's working perfectly now. Thanks for the fix!

I'll resolve the bug.