Bug 410

Summary: visudo infinite recursion bug
Product: Sudo Reporter: David.Wood
Component: VisudoAssignee: Todd C. Miller <Todd.Miller>
Status: RESOLVED FIXED    
Severity: normal    
Priority: low    
Version: 1.7.2   
Hardware: All   
OS: All   
Attachments: visudo.c patch

Description David.Wood 2010-04-29 04:14:09 MDT 
Created attachment 271 [details]
visudo.c patch

% cat /tmp/sudoers
User_Alias    FOO=joeuser
Cmnd_Alias    BAD=/usr/bin/ls    BAR=ABC,DEF,GHI,BAD
FOO           +all-hosts=(sybase) BAD

% visudo -cf /tmp/sudoers
zsh: segmentation fault (core dumped)  visudo -cf /tmp/sudoers
(runs out of stack space)

After applying the attached patch:

% ./visudo -cf /tmp/sudoers
visudo: Warning: Cmnd_Alias `BAD' references self
/tmp/sudoers: parsed OK
Comment 1 Todd C. Miller 2010-04-29 18:51:48 MDT 
I just committed a modified version of your fix, thanks!