Bug 455

Summary:	Confusing #includedir syntax.
Product:	Sudo	Reporter:	David Anselmi <anselmi>
Component:	Visudo	Assignee:	Todd C. Miller <Todd.Miller>
Status:	RESOLVED FIXED
Severity:	low	CC:	mpartap
Priority:	low
Version:	1.7.4
Hardware:	All
OS:	All

Description David Anselmi 2010-12-11 18:36:23 MST

I was confused by the syntax of the #includedir directive the first time I saw it.  It seems less than ideal to make a directive that starts with the comment character.

I understand the need to distinguish includedir from user names but if we use a C-like directive perhaps we should use C-like comments too.

Or maybe pick a different character?

Please consider it if it isn't too much work.

Thanks!

Comment 1 Marcel Partap 2018-07-15 05:29:13 MDT

I tripped over the same thing, trying to uncomment the includedir line, only to receive an error message..
Not an especially fortunate choice of syntax.

Comment 2 Todd C. Miller 2020-07-01 09:10:47 MDT

Sudo 1.9.1 supports @include and @includedir.  The manual and examples have been updated to prefer the @include syntax, though #include is still supported.