Bug 635

Summary:	Extra output in testsuite for sudo_conf
Product:	Sudo	Reporter:	Dagobert Michelsen <dam>
Component:	Sudo	Assignee:	Todd C. Miller <Todd.Miller>
Status:	RESOLVED FIXED
Severity:	low
Priority:	low
Version:	1.8.10
Hardware:	Sun
OS:	Solaris 2.x

Description Dagobert Michelsen 2014-03-11 02:32:16 MDT

On Solaris 9 Sparc when compiling with Sun Studio 12 there is an extra line in test output which seems to confuse the testing framework:

gmake[1]: Entering directory '/home/dam/mgar/pkg/sudo/trunk/work/solaris9-sparc/build-isa-sparcv8-ldap-enabled/sudo-1.8.10/common'
sudo_conf/test1: OK
sudo_conf/test2: OK
sudo_conf/test3: OK
sudo_conf/test4: OK
conf_test: invalid max groups `0' in ./regress/sudo_conf/test5.in, line 1
sudo_conf/test5: OK
sudo_conf/test6: OK
sudo_parseln/test1: OK
sudo_parseln/test2: OK
sudo_parseln/test3: OK
sudo_parseln/test4: OK
sudo_parseln/test5: OK
sudo_parseln/test6: OK
sudo_parseln: 14/13 tests passed; 0/13 tests failed

The output suggests that now 14 instead of 13 tests are assumed and the failing test is actually ignored.

Comment 1 Todd C. Miller 2014-03-11 09:19:43 MDT

That's actually just an off by one error in the total test count.  The "invalid max groups" is actually expected.  I've modified the check target to compare stderr for that test too and made some other cleanups.  This is what it looks like now:

atofoo_test: 23 tests run, 0 errors, 100% success rate
hltq_test: 19 tests run, 0 errors, 100% success rate
sudo_conf/test1: OK
sudo_conf/test2: OK
sudo_conf/test3: OK
sudo_conf/test4: OK
sudo_conf/test5: OK
sudo_conf/test5 (stderr): OK
sudo_conf/test6: OK
sudo_conf: 7/7 tests passed; 0/7 tests failed
sudo_parseln/test1: OK
sudo_parseln/test2: OK
sudo_parseln/test3: OK
sudo_parseln/test4: OK
sudo_parseln/test5: OK
sudo_parseln/test6: OK
sudo_parseln: 6/6 tests passed; 0/6 tests failed

Comment 2 Todd C. Miller 2014-03-13 18:34:29 MDT

Fixed in sudo 1.8.10p1, available now.