Bug 647

Summary: Patches to fix visudo on hurd
Product: Sudo Reporter: Gabriele Giacone <1o5g4r8o>
Component: ConfigureAssignee: Todd C. Miller <Todd.Miller>
Status: RESOLVED FIXED    
Severity: normal CC: 1o5g4r8o
Priority: low    
Version: 1.8.10   
Hardware: PC   
OS: Other   
Attachments: Use flock instead of lockf for visudo on hurd
Skip installing/unlinking files without doedit set

Description Gabriele Giacone 2014-05-09 05:14:49 MDT
Created attachment 407 [details]
Use flock instead of lockf for visudo on hurd

Attached patches fix visudo on hurd:

use-flock-on-hurd.diff
  Use flock instead of lockf for visudo on hurd

skip-noedit.diff
  Skip installing/unlinking files without doedit set

More info at respective Debian bugs.

Thanks for considering.
Comment 1 Gabriele Giacone 2014-05-09 05:15:51 MDT
Created attachment 408 [details]
Skip installing/unlinking files without doedit set
Comment 2 Todd C. Miller 2014-05-09 09:48:14 MDT
I committed a slightly different fix for the NULL pointer deref: http://www.sudo.ws/repos/sudo/rev/3a677c4773e5


The configure.ac patch is too broad as it may match more than just Hurd.  What does config.guess output on a Hurd system?
Comment 3 Todd C. Miller 2014-05-09 10:04:23 MDT
I found the Hurd porting guide which includes a configure host string for hurd and committed a slightly different diff.

http://www.sudo.ws/repos/sudo/rev/7b8935a0c8b9
Comment 4 Todd C. Miller 2014-09-24 09:30:51 MDT
Fixed in sudo 1.8.11.
Comment 5 Todd C. Miller 2014-09-24 09:31:19 MDT
Fixed in sudo 1.8.11.