Bug 727

Summary:	Build fails in timestamp.c with "void function cannot return value"
Product:	Sudo	Reporter:	Dagobert Michelsen <dam>
Component:	Packaging	Assignee:	Todd C. Miller <Todd.Miller>
Status:	RESOLVED FIXED
Severity:	high
Priority:	low
Version:	1.8.15
Hardware:	Sun
OS:	Solaris 2.x
Attachments:	Fix compilation on Solaris 10 with Sun Studio 12

Description Dagobert Michelsen 2015-11-01 14:57:49 MST

The build of sudo 1.8.15 fails on Solaris 10 with Stun Studio 12:

libtool: compile:  /opt/SUNWspro/bin/cc -D_STDC_C99= -c -I../../include -I../.. -I. -I. -I../.. -DLIBDIR=\"/opt/csw/lib\" -DLOCALEDIR=\"/opt/csw/share/locale\" -D_PATH_SUDOERS=\"/etc/opt/csw/sudoers\" -DSUDOERS_UID=0 -DSUDOERS_GID=0 -DSUDOERS_MODE=0440 -I/opt/csw/include/sasl -I/opt/csw/include -I/opt/csw/lib/include -xO3 -m32 -xarch=sparc -xldscope=hidden ./timestamp.c  -KPIC -DPIC -o .libs/timestamp.o
"./timestamp.c", line 313: warning: initializer does not fit or is out of range: -1  
"./timestamp.c", line 357: void function cannot return value
"./timestamp.c", line 363: void function cannot return value

Comment 1 Todd C. Miller 2015-11-01 15:21:38 MST

Created attachment 464 [details]
Fix compilation on Solaris 10 with Sun Studio 12

Comment 2 Dagobert Michelsen 2015-11-02 03:02:59 MST

The patch fixes the issue, thanks for the quick fix!

I can offer an automatic build with error notification on our Solaris buildfarm to catch these kinds of errors early next time. Would that be interesting for you?

Comment 3 Todd C. Miller 2015-11-02 09:37:57 MST

Sure, that would be useful.  I do my own Solaris builds using a mix of Solaris Studio 12 (for intel) and the old gccfss cross compiler (for sparc).  It would be even better if there was a way to have beta or release candidates build-tested so these kinds of issues get caught earlier.

Comment 4 Dagobert Michelsen 2015-11-05 09:25:49 MST

I emailed you privately about access. This bug can be closed.


Best regards -- Dago

Comment 5 Todd C. Miller 2016-03-17 10:18:13 MDT

Fixed in 1.8.16, available now.