Bug 854

Summary:	Superfluous words in sudoers(5)
Product:	Sudo	Reporter:	Benedict Reuschling <bcr>
Component:	Documentation	Assignee:	Todd C. Miller <Todd.Miller>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	low
Version:	1.8.25
Hardware:	PC
OS:	All
Attachments:	Patches to sudoers.cat, sudoers.man.in, and sudoers.mdoc.in

Description Benedict Reuschling 2018-10-06 05:18:04 MDT

Created attachment 517 [details]
Patches to sudoers.cat, sudoers.man.in, and sudoers.mdoc.in

The sudoers man page contains a repeated "and and". This was originally reported to FreeBSD in this bug:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231994

During the course of investigating this bug, I've found other instances of repeated words, "injecting injecting" for example. In FreeBSD's docs, we use igor to find common errors like this in man pages. It's not perfect and sometimes has false positives, but is still good enough at finding man page bugs. You can find it here:

http://www.wonkity.com/~wblock/igor/

I've attached a patch to fix the superfluous words in sudoers (I did not check other man pages provided by sudo). The bug is present in sudo upstream version 1.8.25. Rather than fixing it locally in FreeBSD only, I'm submitting the fix to the sudo project so that others can get it, too.

Regards,
Benedict

Comment 1 Todd C. Miller 2018-10-06 05:41:05 MDT

Thanks, I've added an "igor" target to the doc Makefile and will fix the things it finds that seem like problems.

Comment 2 Todd C. Miller 2018-10-06 06:01:30 MDT

Fixed in https://www.sudo.ws/repos/sudo/rev/4ddcb625f3b7

Comment 3 Todd C. Miller 2018-11-16 11:13:55 MST

Fixed in sudo 1.8.26.