Bug 409 – visudo -s with unused alias causes segfault

Bug 409 - visudo -s with unused alias causes segfault


Summary:	visudo -s with unused alias causes segfault

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Visudo
Version:	1.7.2
Hardware:	All All

Importance:	low normal
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-29 04:01 MDT by David.Wood
Modified:	2010-04-29 18:25 MDT (History)
CC List:	0 users

See Also:

Attachments
visudo.c patch (620 bytes, text/plain) 2010-04-29 04:01 MDT, David.Wood	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David.Wood 2010-04-29 04:01:20 MDT

Created attachment 270 [details]
visudo.c patch

% cat /tmp/sudoers
User_Alias    FOO=joeuser

% visudo -scf /tmp/sudoers
visudo: Error: unused User_Alias FOO
zsh: segmentation fault (core dumped)  visudo -scf /tmp/sudoers

After applying the attached patch:

% ./visudo -scf /tmp/sudoers
visudo: Error: unused User_Alias FOO
/tmp/sudoers: parse error
/tmp/sudoers: wrong owner (uid, gid) should be (0, 0)
/tmp/sudoers: bad permissions, should be mode 0440

% echo $?
1

Comment 1 Todd C. Miller 2010-04-29 18:25:26 MDT

This is already fixed in the sudo mercurial repo and will be part of the next sudo release.