Bug 410 – visudo infinite recursion bug

Bug 410 - visudo infinite recursion bug


Summary:	visudo infinite recursion bug

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Visudo
Version:	1.7.2
Hardware:	All All

Importance:	low normal
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-29 04:14 MDT by David.Wood
Modified:	2010-04-29 18:51 MDT (History)
CC List:	0 users

See Also:

Attachments
visudo.c patch (3.39 KB, text/plain) 2010-04-29 04:14 MDT, David.Wood	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David.Wood 2010-04-29 04:14:09 MDT

Created attachment 271 [details]
visudo.c patch

% cat /tmp/sudoers
User_Alias    FOO=joeuser
Cmnd_Alias    BAD=/usr/bin/ls    BAR=ABC,DEF,GHI,BAD
FOO           +all-hosts=(sybase) BAD

% visudo -cf /tmp/sudoers
zsh: segmentation fault (core dumped)  visudo -cf /tmp/sudoers
(runs out of stack space)

After applying the attached patch:

% ./visudo -cf /tmp/sudoers
visudo: Warning: Cmnd_Alias `BAD' references self
/tmp/sudoers: parsed OK

Comment 1 Todd C. Miller 2010-04-29 18:51:48 MDT

I just committed a modified version of your fix, thanks!