Bug 455 - Confusing #includedir syntax.
Confusing #includedir syntax.
Status: RESOLVED FIXED
Product: Sudo
Classification: Unclassified
Component: Visudo
1.7.4
All All
: low low
Assigned To: Todd C. Miller
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-11 18:36 MST by David Anselmi
Modified: 2020-07-01 09:10 MDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Anselmi 2010-12-11 18:36:23 MST
I was confused by the syntax of the #includedir directive the first time I saw it.  It seems less than ideal to make a directive that starts with the comment character.

I understand the need to distinguish includedir from user names but if we use a C-like directive perhaps we should use C-like comments too.

Or maybe pick a different character?

Please consider it if it isn't too much work.

Thanks!
Comment 1 Marcel Partap 2018-07-15 05:29:13 MDT
I tripped over the same thing, trying to uncomment the includedir line, only to receive an error message..
Not an especially fortunate choice of syntax.
Comment 2 Todd C. Miller 2020-07-01 09:10:47 MDT
Sudo 1.9.1 supports @include and @includedir.  The manual and examples have been updated to prefer the @include syntax, though #include is still supported.