Bug 486 – redundant code in common/aix.c::getlimits()

Bug 486 - redundant code in common/aix.c::getlimits()


Summary:	redundant code in common/aix.c::getlimits()

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudo
Version:	1.8.1
Hardware:	IBM AIX

Importance:	low low
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-03-30 02:59 MDT by dlaigle
Modified:	2011-04-11 08:02 MDT (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description dlaigle 2011-03-30 02:59:36 MDT

The 'getuserattr()' call will always end up by seeking in the "default" stanza on local files, regardless of the user database (I used LDAP).
Thus, if an attribute in not defined for a user but exists in "default", 'getuserattr(user)' will return the default value.
You don't need to explicitly call 'getuserattr("default")' and therefore you can remove this statement from the code...

Regards

- Dominique

Comment 1 Todd C. Miller 2011-03-30 08:59:52 MDT

Thanks, I'll remove that line in the next release.

Comment 2 Todd C. Miller 2011-04-11 08:02:13 MDT

Fixed in sudo 1.8.1