Bug 647 – Patches to fix visudo on hurd

Bug 647 - Patches to fix visudo on hurd


Summary:	Patches to fix visudo on hurd

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Configure
Version:	1.8.10
Hardware:	PC Other

Importance:	low normal
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-09 05:14 MDT by Gabriele Giacone
Modified:	2014-09-24 09:31 MDT (History)
CC List:	1 user (show)

See Also:

Attachments
Use flock instead of lockf for visudo on hurd (417 bytes, patch) 2014-05-09 05:14 MDT, Gabriele Giacone	Details \| Diff
Skip installing/unlinking files without doedit set (489 bytes, patch) 2014-05-09 05:15 MDT, Gabriele Giacone	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gabriele Giacone 2014-05-09 05:14:49 MDT

Created attachment 407 [details]
Use flock instead of lockf for visudo on hurd

Attached patches fix visudo on hurd:

use-flock-on-hurd.diff
  Use flock instead of lockf for visudo on hurd

skip-noedit.diff
  Skip installing/unlinking files without doedit set

More info at respective Debian bugs.

Thanks for considering.

Comment 1 Gabriele Giacone 2014-05-09 05:15:51 MDT

Created attachment 408 [details]
Skip installing/unlinking files without doedit set

Comment 2 Todd C. Miller 2014-05-09 09:48:14 MDT

I committed a slightly different fix for the NULL pointer deref: http://www.sudo.ws/repos/sudo/rev/3a677c4773e5


The configure.ac patch is too broad as it may match more than just Hurd.  What does config.guess output on a Hurd system?

Comment 3 Todd C. Miller 2014-05-09 10:04:23 MDT

I found the Hurd porting guide which includes a configure host string for hurd and committed a slightly different diff.

http://www.sudo.ws/repos/sudo/rev/7b8935a0c8b9

Comment 4 Todd C. Miller 2014-09-24 09:30:51 MDT

Fixed in sudo 1.8.11.

Comment 5 Todd C. Miller 2014-09-24 09:31:19 MDT

Fixed in sudo 1.8.11.