Bug 662 – Build system makes a wrong cross-compiler assumption

Bug 662 - Build system makes a wrong cross-compiler assumption


Summary:	Build system makes a wrong cross-compiler assumption

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudo
Version:	1.8.10
Hardware:	PC Linux

Importance:	low low
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-20 04:49 MDT by Gustavo Zacarias
Modified:	2014-09-24 09:33 MDT (History)
CC List:	0 users

See Also:

Attachments
Don't use CPPFLAGS/PIEFLAGS for host tools (1.08 KB, patch) 2014-09-20 04:49 MDT, Gustavo Zacarias	Details \| Diff
Don't use SSP_CFLAGS/PIE_CFLAGS for host tools (1.08 KB, patch) 2014-09-20 04:52 MDT, Gustavo Zacarias	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo Zacarias 2014-09-20 04:49:25 MDT

Created attachment 427 [details]
Don't use CPPFLAGS/PIEFLAGS for host tools

When cross-compiling sudo host compiler != cross compiler.
The host tools (mksigname/mksiglist) are built using CPPFLAGS/PIEFLAGS which are tested against the cross compiler, and since the host compiler can be a wildly different version this may make the build fail.
Example:
http://autobuild.buildroot.net/results/b10/b1091bd04ab988744548b74fb48c64bf291fed2f/build-end.log
Since the tools aren't part of sudo runtime we can just remove those compiler flags.

Comment 1 Gustavo Zacarias 2014-09-20 04:52:04 MDT

Created attachment 428 [details]
Don't use SSP_CFLAGS/PIE_CFLAGS for host tools

Comment 2 Gustavo Zacarias 2014-09-20 04:52:39 MDT

Coffee didn't take yet, it's early here, adjusted patch/comment since it's SSP_CFLAGS/PIE_CFLAGS. Sorry for the noise.

Comment 3 Todd C. Miller 2014-09-20 06:46:50 MDT

Thanks, that patch will be in sudo 1.8.11.

Comment 4 Todd C. Miller 2014-09-24 09:33:41 MDT

Fixed in sudo 1.8.11.