Bug 672 – make check fails if running in the environment with non-english/C locale settings

Bug 672 - make check fails if running in the environment with non-english/C locale settings


Summary:	make check fails if running in the environment with non-english/C locale sett...

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudoers
Version:	1.8.11
Hardware:	PC Linux

Importance:	normal normal
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-14 07:26 MDT by chaonautic
Modified:	2015-02-09 15:12 MST (History)
CC List:	1 user (show)

See Also:

Attachments
console output with ukrainian locale (check fails) and then with C locale (check passes). (8.68 KB, text/plain) 2014-10-14 07:26 MDT, chaonautic	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description chaonautic 2014-10-14 07:26:58 MDT

Created attachment 434 [details]
console output with ukrainian locale (check fails) and then with C locale (check passes).

when running „make check“ after sudo compilation in the environment with non-english/C locale settings, it fails (see attachment for the output).

if locale is set to C or en_US (not tested with other english locales), „make check“ for the same compilation succeeds.

as far i can see, failing tests rely on error messages instead of locale-agnostic exit codes or so.

Comment 1 Todd C. Miller 2014-10-14 08:56:23 MDT

I've committed a change to run those tests in the C locale, http://www.sudo.ws/repos/sudo/rev/adf7997a0a65

Those tests use visudo and testsudoers so they need to be run in the C locale so that the output matches.

Comment 2 Todd C. Miller 2015-02-09 15:12:52 MST

Fixed in sudo 1.8.12, available now.