Bug 837 – get_starttime: incorrect conversions from timeval to timespec

Bug 837 - get_starttime: incorrect conversions from timeval to timespec


Summary:	get_starttime: incorrect conversions from timeval to timespec

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudoers
Version:	1.8.23
Hardware:	All OpenBSD

Importance:	low low
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-06-04 18:57 MDT by Scott Cheloha
Modified:	2018-08-18 13:26 MDT (History)
CC List:	0 users

See Also:

Attachments
Patch for sudoers/starttime.c (992 bytes, application/octet-stream) 2018-06-04 18:57 MDT, Scott Cheloha	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Scott Cheloha 2018-06-04 18:57:35 MDT

Created attachment 510 [details]
Patch for sudoers/starttime.c

These conversions in get_starttime() look off.  Shouldn't you multiply by 1000 to convert usec to nsec?

Comment 1 Todd C. Miller 2018-06-04 20:08:07 MDT

Thanks, committed as https://www.sudo.ws/repos/sudo/rev/26fa756ea623

Comment 2 Todd C. Miller 2018-08-18 13:26:54 MDT

Fixed in sudo 1.8.24, available now.