Bug 845 – sudoNotAfter (LDAP) not working

Bug 845 - sudoNotAfter (LDAP) not working


Summary:	sudoNotAfter (LDAP) not working

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudoers
Version:	1.8.24
Hardware:	PC Linux

Importance:	low normal
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-08-20 04:10 MDT by Miguel Sanders
Modified:	2018-09-05 06:28 MDT (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Miguel Sanders 2018-08-20 04:10:59 MDT

Hi

I just upgraded to 1.8.24 and found out that sudoNotAfter (LDAP) is not working. This is caused by the following bug in ldap_util.c (lines 388-389)

  +388              if (notafter != NULL)
  +389                  cmndspec->notbefore = parse_gentime(notafter);

Should be

  +388              if (notafter != NULL)
  +389                  cmndspec->notafter = parse_gentime(notafter);


Can you please push this for the next version?

Many thanks!

Comment 1 Todd C. Miller 2018-08-20 05:51:41 MDT

Thanks for noticing that and tracking down my cut & pasto.
This is fixed in https://www.sudo.ws/repos/sudo/rev/69638cd6da60

Comment 2 Todd C. Miller 2018-09-05 06:28:25 MDT

Fixed in sudo 1.8.25