Bug 873 – Regression in 1.8.27 - cvtsudoers/test32: FAIL; possible buffering issue

Bug 873 - Regression in 1.8.27 - cvtsudoers/test32: FAIL; possible buffering issue


Summary:	Regression in 1.8.27 - cvtsudoers/test32: FAIL; possible buffering issue

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudoers
Version:	1.8.27
Hardware:	IBM Linux

Importance:	low normal
Assigned To:	Todd C. Miller

URL:

Duplicates:	881 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-03-07 22:21 MST by A. Wilcox
Modified:	2019-05-08 13:23 MDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description A. Wilcox 2019-03-07 22:21:24 MST

Sudo 1.8.25p1 passes its test suite just fine.  1.8.27 does not:


cvtsudoers/test32: FAIL
0a1
> cvtsudoers: too many sudoers entries, maximum 10
116,117c117
< sudoHost: ALLcvtsudoers: too many sudoers entries, maximum 10
< 
---
> sudoHost: ALL


This seems to me to be an issue with stdio buffering, since the error is printed at the very end of the output instead of the very beginning of the output as expected.  This test was done on Adélie Linux, which uses the musl libc (not glibc).

Comment 1 Todd C. Miller 2019-03-08 06:42:03 MST

Yes, this is a buffering issue.  It is probably best to just test stdout and stderr separately.

Comment 2 Todd C. Miller 2019-03-08 07:02:39 MST

Fixed by https://www.sudo.ws/repos/sudo/rev/e82a381f4f3d

Comment 3 A. Wilcox 2019-03-08 16:17:17 MST

Just tested this change locally and the test suite now passes.  Thank you so much!

Comment 4 Todd C. Miller 2019-05-08 13:23:42 MDT

*** Bug 881 has been marked as a duplicate of this bug. ***