Bug 947 – lib/eventlog/eventlog.c uses _PATH_SUDO_SENDMAIL unconditionally

Bug 947 - lib/eventlog/eventlog.c uses _PATH_SUDO_SENDMAIL unconditionally


Summary:	lib/eventlog/eventlog.c uses _PATH_SUDO_SENDMAIL unconditionally

Status:	RESOLVED FIXED

Product:	Sudo
Classification:	Unclassified
Component:	Sudo
Version:	1.9.4
Hardware:	PC Linux

Importance:	low normal
Assigned To:	Todd C. Miller

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-11-30 13:01 MST by torcontact1
Modified:	2020-12-17 15:00 MST (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description torcontact1 2020-11-30 13:01:05 MST

Hi!

Sudo 1.9.4 can no longer be built without ‘--with-sendmail’ or with ‘--without-sendmail’:

./eventlog.c:94:5: error: ‘_PATH_SUDO_SENDMAIL’ undeclared here (not in a function); did you mean ‘_PATH_SENDMAIL’?
     _PATH_SUDO_SENDMAIL, /* mailerpath */
     ^~~~~~~~~~~~~~~~~~~
     _PATH_SENDMAIL
make[1]: *** [Makefile:218: eventlog.lo] Error 1

Like plugins/sudoers/defaults.c, lib/eventlog/eventlog.c should guard against this with an #ifdef _PATH_SUDO_SENDMAIL.

Thanks for sudo!

T

Comment 1 Todd C. Miller 2020-11-30 13:19:08 MST

Thanks for the report, fixed by https://www.sudo.ws/repos/sudo/rev/41db1aad85bb

Comment 2 Todd C. Miller 2020-12-17 15:00:12 MST

Fixed in sudo 1.9.4p1